Change minimum amount for installment payments from 3000 to 2000 THB#210
Merged
kan98 merged 1 commit intoomise:masterfrom Apr 19, 2021
som-m:master
Merged
Change minimum amount for installment payments from 3000 to 2000 THB#210kan98 merged 1 commit intoomise:masterfrom som-m:master
kan98 merged 1 commit intoomise:masterfrom
som-m:master
Conversation
kan98
approved these changes
Apr 9, 2021
Contributor
kan98
left a comment
There was a problem hiding this comment.
I think it might be beneficial to add a unit test to check we can create a 2,000 THB installment and a test that we can't create installments below that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0. To-Do
1. Objective
Change the display amount for installment payments from 3000 to 2000 THB WooCommerce.
Reference: https://www.omise.co/installment-payments#limits
Related information:
Related issue(s): #209
Related PR(s): #211
Internal task(s): CS-649
2. Description of change
Change the display amount for installment payments from 3000 to 2000 THB. This is shown installment is selected and the amount is less than 2000 THB.
3. Quality assurance
🔧 Environments:
✏️ Details:
Installment option should appear when the amount is at least 2000 THB. Otherwise, this message should be displayed:
There are no installment plans available for this purchase amount (minimum amount is 2,000 THB).4. Impact of the change
The correct minimum amount is shown.
5. Priority of change
Normal
6. Additional Notes
n/a