Adding permission to callback which helps to removes a warning message on Wordpress 5.5.#188
Merged
mayurkathale merged 1 commit intomasterfrom Sep 8, 2020
Merged
Adding permission to callback which helps to removes a warning message on Wordpress 5.5.#188mayurkathale merged 1 commit intomasterfrom
mayurkathale merged 1 commit intomasterfrom
Conversation
Contributor
|
@mayurkathale can you let me know when ready for review? |
danfowler
approved these changes
Sep 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Objective
Warning messages are shown on Admin backend page regarding rest api once Wordpress version is upgraded to 5.5. This messages are shown on backend page or error logs.
Warning message screenshot (WooCommerce product page):
Related information:
Internal Ticket: https://phabricator.omise.co/T22923
2. Description of change
Updated PHP class Omise_Rest_Webhooks_Controller. Added "permission_callback" parameter to register_rest_route() which defines this webhook as Public.
Adding this parameter is required in Wordpress 5.5 and warning message gets removed.
3. Quality assurance
🔧 Environments:
✏️ Details:
Try to visit admin backend pages this should not display any error message. e.g. Edit Product page.
4. Impact of the change
NA
5. Priority of change
Normal
6. Additional Notes
NA