Conversation
4f84362 to
cef8caa
Compare
danfowler
approved these changes
Jul 20, 2020
mayurkathale
approved these changes
Jul 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Objective
At the moment, the plugin will leave the order status as
pending paymentfor a successful 'auth-only' Credit Card payment method. As the original idea, we were assuming that theauthorizedcharge status (charge.authorized=true,charge.paid=false,charge.status=pending) is equal as WooCommerce Order pending payment status.However, as researched. It's more correct behaviour to update WC Order status to
processingfor those authorised-charges instead of leaving it aspending payment.2. Description of change
Executing
WC_Order::payment_complete()right at the moment when the charge transaction has authorized (charge.authorized=true,charge.paid=false,charge.status=pending)3. Quality assurance
🔧 Environments:
✏️ Details:
processingif placing order using Credit Card payment method withauth-onlyaction.auto-capture. This simply just to re-order the order-note messages so thewill come first before
4. Impact of the change
The order flow will be changed.
However, as we are in a stage of releasing a major version, I think it is a good time to correct it from the beginning.
5. Priority of change
Normal
6. Additional Notes
None