Integrating WooCommerce refund's reason parameter to Omise Refund object.#165
Merged
Integrating WooCommerce refund's reason parameter to Omise Refund object.#165
Conversation
jonrandy
approved these changes
Apr 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Objective
WooCommerce has provided a "reason" field for merchant to add a comment on the refund transaction. However, it hasn't been integrated to Omise Refund object.
Since Omise Refund API accepts for metadata parameter, it would be best to integrate it now.
Related information:
Internal ticket (T20652)
2. Description of change
There is nothing change in the term of UI. However, merchant now, can check for their refund's reason at Omise Dashboard as well.
3. Quality assurance
🔧 Environments:
✏️ Details:
Making sure that merchant can create a refund with a reason-adding.
Entering any message to the Reason for refund (optional) field.

At Omise `metadata.reason`, it will show as empty string.4. Impact of the change
No
5. Priority of change
Normal
6. Additional Notes
I think it would be nice if the coming metadata name is broadly used in another of Omise plugins as well, so please feel free to discuss about the naming there. (This PR is introducing
$refund['metadata']['reason']).