Skip to content

Introducing TrueMoney payment (only available in Thailand) #139

Merged
guzzilar merged 9 commits intomasterfrom
true-wallet-payment
Oct 7, 2019
Merged

Introducing TrueMoney payment (only available in Thailand) #139
guzzilar merged 9 commits intomasterfrom
true-wallet-payment

Conversation

@guzzilar
Copy link
Copy Markdown
Contributor

1. Objective

Explain in non-technical terms WHY this PR is required.
E.g.: What feature it adds, what problem it solves...

This section will be used in the release notes.

2. Description of change

Adding functionalities that support for Omise, TrueMoney payment.

  • Implementing all the necessary foundation code.
  • Displaying TrueMoney payment method on both WordPress's Omise setting page and WooCommerce's checkout page.
  • Handle TrueMoney payment result.

All the necessary details are listed in each commit. You may refer it from these 8 commits in this pull request.

  • TrueMoney: implementing a foundation code to list the payment at the WC payment setting page.
  • TrueMoney: listing TrueMoey Wallet payment method at the admin Omise Setting Page.
  • TrueMoney: Be able to save the payment settings to WC configuration db.
  • TrueMoney: Be able to create a new charge.
  • TrueMoney: Displaying form field.
  • TrueMoney: Be able to create a charge using Billing Details' phone number.
  • TrueMoney: Implementing callback function.
  • TrueMoney: Be able to use different phone number from Billing Details to receive OTP, at the checkout form.

3. Quality assurance

🔧 Environments:

  • PHP version: 7.3.3
  • WordPress: v5.2.3
  • WooCommerce: v3.7.0

✏️ Details:

drafting...

4. Impact of the change

No

5. Priority of change

Normal

6. Additional Notes

This payment is available only in Thailand.
For more information, please check the official document: https://www.omise.co/truemoney

@jacstn
Copy link
Copy Markdown
Contributor

jacstn commented Oct 3, 2019

would you consider to show this number?

image

I see an advantage to display saved number, so I don't need to leave this page and double-check what number I have saved there.

@guzzilar
Copy link
Copy Markdown
Contributor Author

guzzilar commented Oct 3, 2019

@jacstn good point 👍
With a guest account, it requires users to fill their phone number to a form at the same page.
But I should experience with a logged-in account and some theme that has separated Billing Detail information page and a payment method page.

Will get back to you soon on this.

@jacstn
Copy link
Copy Markdown
Contributor

jacstn commented Oct 7, 2019

tested manually, works well.

@guzzilar guzzilar merged commit 4c79a8e into master Oct 7, 2019
@guzzilar guzzilar deleted the true-wallet-payment branch October 7, 2019 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants