Migrating all related code to support Omise API version v2017-11-02.#102
Merged
Migrating all related code to support Omise API version v2017-11-02.#102
Conversation
Note, this update is to prepare the code for Installment feature.
Contributor
Author
|
added |
jacstn
approved these changes
Feb 21, 2019
jonrandy
reviewed
Feb 22, 2019
jonrandy
reviewed
Feb 22, 2019
…zed and isPaid methods).
b1e3650 to
0c8d9d7
Compare
Contributor
Author
jonrandy
approved these changes
Feb 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Objective
The upcoming implementation for the Installment payment is required for the latest Omise API version,
2017-11-02which the current core-code of the plugin doesn't support.This pull request is aiming to migrate all related code to support the Omise API version
2017-11-02.2. Description of change
All code should function the same except now we are switching Omise API to the latest version,
2017-11-02, which support Source API.3. Quality assurance
🔧 Environments:
✏️ Details:
Expected result:
To make sure that the plugin would still be able to create a new Alipay charge after migrate to the new API version.
Expected result:
To make sure that the plugin would still be able to create a new Internet Banking charge after migrate to the new API version.
Expected result:
To make sure that the
charge.capturedevent handler can make a proper decision as some part of this code has bene migrated to support the latest Omise API version as well.charge.completeevent & observe its behaviourExpected result:
To make sure that the
charge.completeevent handler can make a proper decision as some part of this code has bene migrated to support the latest Omise API version as well..
The left, for successful case, and the right side is for failure case.
4. Impact of the change
No
5. Priority of change
Normal
6. Additional Notes
No