Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes the WooCommerce passkey settings feature flag (OMISE_FEATURE_PASSKEY) and related configuration options, shifting to reliance on account-level passkey settings. The passkey order note functionality is retained to provide merchants visibility into passkey-authenticated transactions.
Key Changes:
- Removed passkey feature flag and settings UI from WooCommerce payment configuration
- Removed passkey authentication logic from charge creation flow
- Removed passkey-related test cases and assertions
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
includes/gateway/class-omise-payment-creditcard.php |
Removed passkey settings initialization from credit card payment gateway form fields |
includes/gateway/abstract-omise-payment-base-card.php |
Removed conditional passkey authentication logic from charge data preparation |
includes/blocks/gateways/omise-block-credit-card.php |
Removed is_passkey_enabled flag from payment method data sent to blocks |
tests/unit/includes/gateway/class-omise-payment-creditcard-test.php |
Removed test verifying passkey setting inclusion when feature flag is enabled |
tests/unit/includes/gateway/abstract-omise-payment-base-card-test.php |
Removed tests for passkey authentication with WooCommerce blocks and shortcodes, updated existing test to remove passkey setting |
tests/unit/includes/blocks/gateways/omise-block-credit-card-test.php |
Removed passkey flag from mock settings and corresponding assertion in payment method data test |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
FhanOmise
approved these changes
Nov 24, 2025
AnasNaouchi
approved these changes
Nov 24, 2025
nattanonch
approved these changes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove passkey feature variable that is controlling passkey settings on WooCommerce. We're going to completely rely on the account settings.
However, the order note for passkey is still being kept. If the transaction uses passkey, merchant will be able to see it in the order note.
Related links:
Rollback procedure
default rollback procedure