[MIT-3467] Fix WooCommerce installment order description#534
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the WooCommerce installment order description by removing hardcoded values and implementing support for custom WLB (White Label Banking) order descriptions through environment variables.
Key changes:
- Removed hardcoded "staging" description from installment charges
- Added support for custom WLB order descriptions via
OMISE_CUSTOM_WLB_ORDER_DESCenvironment variable - Enhanced test coverage for the new description functionality
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| includes/gateway/class-omise-payment-installment.php | Implements custom WLB order description logic with environment variable support |
| tests/unit/includes/gateway/class-omise-payment-installment-test.php | Adds comprehensive test coverage for installment charge functionality and custom descriptions |
| tests/unit/includes/gateway/abstract-omise-payment-offsite-test.php | Refactors test infrastructure to support parameterized charge testing |
| tests/unit/includes/gateway/bootstrap-test-setup.php | Enhances order mock to support additional properties and consistent currency formatting |
| tests/unit/includes/gateway/class-omise-payment-atome-test.php | Updates test to use new testing infrastructure |
| tests/unit/includes/gateway/class-omise-payment-creditcard-test.php | Removes redundant WC_VERSION constant definition |
| tests/unit/includes/gateway/class-omise-payment-googlepay-test.php | Removes redundant WC_VERSION constant definition |
new4762
approved these changes
Aug 1, 2025
AnasNaouchi
approved these changes
Aug 1, 2025
Narum11
approved these changes
Aug 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related links:
Rollback procedure
default rollback procedure