Skip to content
This repository was archived by the owner on Dec 5, 2021. It is now read-only.

custom messenger + relayer#54

Merged
CAPtheorem merged 34 commits intodevelopfrom
souradeep/fast_relayer
Jun 10, 2021
Merged

custom messenger + relayer#54
CAPtheorem merged 34 commits intodevelopfrom
souradeep/fast_relayer

Conversation

@souradeep-das
Copy link
Copy Markdown

@souradeep-das souradeep-das commented Jun 9, 2021

No description provided.

CAPtheorem and others added 30 commits June 1, 2021 14:55
@CAPtheorem
Merge omgx_contracts into /optimism monorepo; integrate message-relay…
aea9661 
…er-fast; and connect up message-relayer-fast with the Dockers/ops
@CAPtheorem
further cleanup
bf35bbb
@CAPtheorem
get address from addressManager; add tests for the message-relayer-fast
c9892f9
@CAPtheorem
testing contract deployments to the new stack
7f6fc0d
@CAPtheorem
Deployment working....
19ae3ac
@boyuan-chen
Add fast and slow message contracts (#38)
8843ca9
@CAPtheorem
wip - simplify system - remove message-relayer-fast
a3147ce
@CAPtheorem
Update L1LiquidityPool.sol
978efd4
@CAPtheorem
message relay working
a2820c8
@CAPtheorem
almost there
8117c5f
@CAPtheorem
major wallet functions confirmed working - ready
e2d84ea
@CAPtheorem
Merge branch 'develop' into integrate-message-relayer-fast
72987da
@CAPtheorem
fix integration tests
887fd9a
@CAPtheorem
minor tweaks to get everything to run on rebased develop branch
1cf7ee7
@CAPtheorem
Integrate #37, confirm compilation and function
2c9bf82
@CAPtheorem
update .env.example for stable rinkeby endpoint
8eea151
@CAPtheorem
adds the message-relayer-fast - goal is to end up with self contained…
9a3efd5 
… folder for this service and associated tests
@boyuan-chen
Added whitelist (#44)
06a23d0
@CAPtheorem
beginning of a fast relayer with unit tests
4b0ba5d
@CAPtheorem
basics are working
07715eb
@souradeep-das
feat: modify tests to add custom messenger
7c5b9b0
@souradeep-das
feat: make messenger address pluggable
a2c6fd3
@souradeep-das
feat: depl local
4f06aba
@souradeep-das
feat: register custom messenger
be8d53b
@souradeep-das
feat: automate
8f53a18
@souradeep-das
feat: automate
1f74506
@souradeep-das
feat: add options for using own custom messegner with service
1400dc1
@souradeep-das
feat: add options for using own custom messegner with service
6c04efe
@souradeep-das
merge master
10a9408
@souradeep-das
merge master
4447087
@souradeep-das souradeep-das marked this pull request as ready for review June 9, 2021 14:53
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 9, 2021 •
edited
Loading

Codecov Report

Merging #54 (0a2aaac) into develop (4a7e3cf) will not change coverage.
The diff coverage is n/a.

❗ Current head 0a2aaac differs from pull request most recent head 154ffcb. Consider uploading reports for the commit 154ffcb to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #54   +/-   ##
========================================
  Coverage    82.14%   82.14%           
========================================
  Files           49       49           
  Lines         1904     1904           
  Branches       304      304           
========================================
  Hits          1564     1564           
  Misses         340      340

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a7e3cf...154ffcb. Read the comment docs.

CAPtheorem
CAPtheorem approved these changes Jun 9, 2021
View reviewed changes
Copy link
Copy Markdown

@CAPtheorem CAPtheorem left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works/all good. Minor suggestion - we currently have four(?) names for this: _alt, ALT, custom, and fast. e.g. message-relayer-fast, L1_ALT_MESSENGER, WatcherAltMessenger, OVM_L1CustomCrossDomainMessenger. Suggestion: standardize to -fast and _FAST, for example, depending on context.

@souradeep-das
Copy link
Copy Markdown
Author

souradeep-das commented Jun 10, 2021

absolutely 👍
renamed them

@CAPtheorem CAPtheorem merged commit 9a2f10b into develop Jun 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@CAPtheorem CAPtheorem CAPtheorem approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-ts-packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@souradeep-das @codecov-commenter @CAPtheorem @boyuan-chen