Skip to content
This repository was archived by the owner on Dec 5, 2021. It is now read-only.

rmi images not needed anymore on master#464

Merged
InoMurko merged 1 commit intodevelopfrom
inomurko/fix_master_publish_image
Sep 16, 2021
Merged

rmi images not needed anymore on master#464
InoMurko merged 1 commit intodevelopfrom
inomurko/fix_master_publish_image

Conversation

@InoMurko
Copy link
Copy Markdown

No description provided.

@InoMurko InoMurko changed the title rmi images not needed anymore rmi images not needed anymore on master Sep 16, 2021
@InoMurko InoMurko requested a review from petardenev September 16, 2021 15:17
Copy link
Copy Markdown

@petardenev petardenev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #464 (61d9bd5) into develop (cd660f5) will increase coverage by 9.95%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #464      +/-   ##
===========================================
+ Coverage    76.09%   86.05%   +9.95%     
===========================================
  Files           81       49      -32     
  Lines         3037     1936    -1101     
  Branches       469      307     -162     
===========================================
- Hits          2311     1666     -645     
+ Misses         726      270     -456     
Flag Coverage Δ
batch-submitter ?
contracts 86.05% <ø> (ø)
core-utils ?
data-transport-layer ?
message-relayer ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/data-transport-layer/src/utils/index.ts
packages/batch-submitter/src/index.ts
packages/core-utils/src/coders/index.ts
packages/data-transport-layer/src/utils/eth-tx.ts
packages/core-utils/src/common/misc.ts
packages/core-utils/src/fees.ts
...h-submitter/src/batch-submitter/batch-submitter.ts
...ckages/data-transport-layer/src/utils/constants.ts
...ubmitter/src/batch-submitter/tx-batch-submitter.ts
...ices/l1-ingestion/handlers/transaction-enqueued.ts
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd660f5...61d9bd5. Read the comment docs.

@InoMurko InoMurko merged commit 253b7ae into develop Sep 16, 2021
@InoMurko InoMurko deleted the inomurko/fix_master_publish_image branch September 16, 2021 15:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants