Skip to content

Conversation

@akx
Copy link
Contributor

@akx akx commented Dec 17, 2024

This PR upgrades Ruff (closes #415) and enables Ruff import sorting.

@akx akx force-pushed the sorted branch 2 times, most recently from 2549afb to b51a8cd Compare December 30, 2024 07:19
@akx
Copy link
Contributor Author

akx commented Jan 14, 2025

@ParthSareen Rebased. Can you take a peek?

@ParthSareen
Copy link
Member

Hey @akx, the from ollama import chat is done on purpose to keep the examples small and simple. IMO it's just cleaner to have chat(...) vs. ollama.chat(...) for every instance.

I'm down for ruff sorting though - but please try to keep the diff small

@akx
Copy link
Contributor Author

akx commented Jan 14, 2025

Hey @akx, the from ollama import chat is done on purpose to keep the examples small and simple. IMO it's just cleaner to have chat(...) vs. ollama.chat(...) for every instance.

My reasoning here was that it's easier to see where these imports are coming from. But I can rip that commit out of this PR, nbd. (That's why I do atomic commits.)

@akx akx requested a review from ParthSareen January 14, 2025 20:13
@akx akx changed the title chore: ensure imports are sorted; unify import styles chore: ensure imports are sorted Jan 14, 2025
@ParthSareen
Copy link
Member

Appreciate it! @akx

@ParthSareen
Copy link
Member

Thanks for this! @akx

@ParthSareen ParthSareen merged commit 89e719a into ollama:main Jan 15, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants