cmake: build llama UI embedder for host arch#16502
Open
puneetdixit200 wants to merge 1 commit into
Open
Conversation
|
Working perfectly, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
llama-ui-embedllama-uilibrary and llama-server objects on the requestedCMAKE_OSX_ARCHITECTURESsliceamd64builds on Apple Silicon hosts without requiring Rosetta just to run the build-time UI embedderFixes #16500.
Testing
cmake -DPATCH_DIR=/tmp/ollama-16500/llama/compat -P /tmp/ollama-16500/llama/compat/apply-patch.cmakecmake -S llama/server -B build/test-llama-server-amd64-ui-host ... -DCMAKE_OSX_ARCHITECTURES=x86_64 -DCMAKE_OSX_DEPLOYMENT_TARGET=14.0cmake --build build/test-llama-server-amd64-ui-host --target llama-ui-assets --parallel 4file build/test-llama-server-amd64-ui-host/_deps/llama_cpp-build/tools/ui/llama-ui-embed-hostThe generated rules build
llama-ui-embed-hostwithout-arch x86_64, whilellama-uistill compiles with-arch x86_64. The helper was reported asMach-O 64-bit executable arm64andllama-ui-assetscompleted.