Conversation
jmorganca
reviewed
Oct 21, 2025
jmorganca
reviewed
Oct 21, 2025
jmorganca
reviewed
Oct 21, 2025
middleware/openai.go
Outdated
| if inputArray, ok := req.Input.([]any); ok { | ||
| if len(inputArray) > 0 { | ||
| if _, isNestedArray := inputArray[0].([]any); isNestedArray { | ||
| c.AbortWithStatusJSON(http.StatusBadRequest, openai.NewError(http.StatusBadRequest, "Tokenized input not supported. Please send text input instead of token IDs.")) |
Member
There was a problem hiding this comment.
Double check that this error is similar to the one OpenAI sends, it seems close!
Contributor
Author
There was a problem hiding this comment.
Hmm nevermind - openAI supports tokenized input (however we do not). I think this directly relates to this issue?
I removed the validation but lmk if you prefer keeping it until the fix is implemented!
jmorganca
reviewed
Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHAT
added support for encoding_format param in OpenAI-compatible
/v1/embeddingsendpoint, allows clients to request embeddings in either float (JSON array) or base64 (base64-encoded string) format.WHY
The /v1/embeddings endpoint was not respecting the encoding_format parameter that OpenAI clients send in requests. This caused compatibility issues with:
CHANGES