build(testenv): mine_empty_blocks requires std feature#4
Closed
ValuedMammal wants to merge 6 commits intooleonardolima:deps/bump-electrsd-versionfrom
Closed
build(testenv): mine_empty_blocks requires std feature#4ValuedMammal wants to merge 6 commits intooleonardolima:deps/bump-electrsd-versionfrom
mine_empty_blocks requires std feature#4ValuedMammal wants to merge 6 commits intooleonardolima:deps/bump-electrsd-versionfrom
Conversation
- upgrades the `electrsd` to latest `0.36.1`. - updates the `electrsd` features to use `corepc-node_28_2`, it's the previously named `bitcoind`. - introduce `bitcoin` as a dependency, in order to use the `bitcoind/rand-std` feature, which is now toggled by `bdk_testenv/std`. - remove the MSRV pinned `home` dependency, it's not currently required.
- introduces `ClientExt` trait to `bdk_bitcoind_rpc` common tests module. - update all `bdk_bitcoind_rpc` tests to build the `Emitter` using the `ClientExt` trait, which allows it to use the old `bitcoincore-rpc::RpcApi` with the corepc-node background.
- updates tests that relies on `bdk_testenv` to it's new `corepc-node` APIs.
Feature-gate TestEnv methods `mine_empty_blocks`, `reorg_empty_blocks` behind `std` feature, as they depend on `rand` which is only available when `std` feature is enabled.
5 tasks
d148921 to
303cc70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Feature-gate TestEnv methods
mine_empty_blocks,reorg_empty_blocksbehindstdfeature, as they depend onrandwhich is only available whenstdfeature is enabled.Clean up stale API docs in
bdk_testenv.