test(bitcoind_rpc): Add common module#3
Closed
ValuedMammal wants to merge 3 commits intooleonardolima:deps/bump-electrsd-versionfrom
Closed
test(bitcoind_rpc): Add common module#3ValuedMammal wants to merge 3 commits intooleonardolima:deps/bump-electrsd-versionfrom
common module#3ValuedMammal wants to merge 3 commits intooleonardolima:deps/bump-electrsd-versionfrom
Conversation
5 tasks
Owner
|
I'll rebase both my branch and this one to get the CI fixes. |
- FIXME: update `bitcoind_rpc` to use `corepc-{node|client}` instead.
366c9d9 to
a2784f5
Compare
The `common` module introduces `ClientExt` trait for easily creating a RPC client of the type that is expected by the core library code.
ac22c53 to
502fd32
Compare
Owner
|
Thanks for the suggestion, I'll cherry-pick this one and update the remaining tests. |
33be1c7 to
a83a8fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
commonmodule introducesClientExttrait for easily creating a RPC client of the type that is expected by the core library code.