Skip to content

Proposing EvaluatorBase.CompileFile for consistency with EvaluatorBase.CompileAssemblyFromFile #447

@maettu-this

Description

@maettu-this

EvaluatorBase currently provides CompileMethod() and CompileCode(), but no CompileFile(). However:

  • The class provides CompileAssemblyFromCode() and CompileAssemblyFromFile().
  • The class' protected Compile method provides both parameters:
    Compile(string scriptText, string scriptFile, CompileInfo info)

To me, this interface is a bit inconsistent and I would prefer a CompileFile() method over having to call CompileCode(File.ReadAllText(scriptFile).

Goodie:
EvaluatorBase Line #777 and EvaluatorBase Line #827 could then also use CompileFile() rather than having to duplicate File.ReadAllText(scriptFile).

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions