Skip to content

Fix nonce issue for replay attack#544

Merged
KamiD merged 2 commits intodevfrom
ray/Fix-nonce-issue-for-replay-attack
Jan 8, 2021
Merged

Fix nonce issue for replay attack#544
KamiD merged 2 commits intodevfrom
ray/Fix-nonce-issue-for-replay-attack

Conversation

@summerpro
Copy link
Contributor

@summerpro summerpro commented Jan 8, 2021 •
edited by zhongqiuwood
Loading

Closes: cosmos/ethermint#687

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@codecov-io
Copy link

codecov-io commented Jan 8, 2021

Codecov Report

Merging #544 (1be8fd3) into dev (f433c50) will not change coverage.
The diff coverage is 20.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #544   +/-   ##
=======================================
  Coverage   68.17%   68.17%           
=======================================
  Files         303      303           
  Lines       18370    18370           
=======================================
  Hits        12523    12523           
  Misses       5131     5131           
  Partials      716      716
Impacted Files Coverage Δ
app/rpc/namespaces/eth/api.go 0.00% <0.00%> (ø)
app/ante/eth.go 58.90% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f433c50...1be8fd3. Read the comment docs.

ilovers
ilovers reviewed Jan 8, 2021
View reviewed changes
@KamiD KamiD merged commit b6dc1e0 into dev Jan 8, 2021
@zhongqiuwood zhongqiuwood deleted the ray/Fix-nonce-issue-for-replay-attack branch January 12, 2021 23:20
@summerpro summerpro mentioned this pull request Jan 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilovers ilovers ilovers approved these changes

@louisliu2048 louisliu2048 louisliu2048 approved these changes

+1 more reviewer

@AaronZgl AaronZgl AaronZgl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Replay Tx on another Chain

6 participants

@summerpro @codecov-io @ilovers @AaronZgl @louisliu2048 @KamiD