Refactor "Devices" tab from List to Table from SwiftUI#84
Merged
okwasniewski merged 5 commits intookwasniewski:mainfrom Oct 31, 2023
jaworek:devices-refactor
Merged
Refactor "Devices" tab from List to Table from SwiftUI#84okwasniewski merged 5 commits intookwasniewski:mainfrom jaworek:devices-refactor
okwasniewski merged 5 commits intookwasniewski:mainfrom
jaworek:devices-refactor
Conversation
jaworek
commented
Oct 29, 2023
Owner
okwasniewski
left a comment
There was a problem hiding this comment.
Thanks for contributing! I've left few minor comments
Contributor
Author
|
Thanks for the quick review! I've addressed all suggestions :D |
Owner
okwasniewski
left a comment
There was a problem hiding this comment.
When I launched the example files weren't added to Xcode (they were on disk) did you push the changes in project.pbxproj?
okwasniewski
approved these changes
Oct 31, 2023
Owner
okwasniewski
left a comment
There was a problem hiding this comment.
Great work, thanks for this! 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #54.
Video recording showing new implementation:
Screen.Recording.Oct.29.mov