feat(parser): use JSON output for iOS simulator parsing#143
Merged
okwasniewski merged 5 commits intomainfrom Jan 17, 2026
Merged
feat(parser): use JSON output for iOS simulator parsing#143okwasniewski merged 5 commits intomainfrom
okwasniewski merged 5 commits intomainfrom
Conversation
Add DeviceFamily enum to properly identify device types (iPhone, iPad, Watch, TV, Vision) from simctl deviceTypeIdentifier. This enables correct icon selection without relying on name matching. - Switch simctl to JSON output (-j flag) - Parse deviceTypeIdentifier for reliable device family detection - Update menu item to use deviceFamily for icon selection - Add comprehensive tests for new parsing logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Refactors iOS simulator device parsing from regex-based text parsing to JSON parsing using
simctl -jflag. IntroducesDeviceFamilyenum to reliably identify device types (iPhone, iPad, Watch, TV, Vision) from thedeviceTypeIdentifierfield instead of matching device names.This fixes incorrect icon assignment for devices like "iPhone 17 Pro with Apple Watch" which previously matched "Watch" in the name.
Changelog:
DeviceFamilyenum with init fromdeviceTypeIdentifiersimctl list devicesto JSON output (-jflag)IOSSimulatorParserto decode JSON instead of regex matchingdeviceFamilyto menu items for correct icon selectionTest Plan:
IOSSimulatorParserShould resolve: #141