feat: add option to hold shift when deleting simulators to skip alert#137
Merged
okwasniewski merged 1 commit intomainfrom Oct 4, 2025
Merged
feat: add option to hold shift when deleting simulators to skip alert#137okwasniewski merged 1 commit intomainfrom
okwasniewski merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds a feature to skip confirmation dialogs when deleting simulators by holding the shift key during the deletion action.
- Modified
DeleteActionto accept askipConfirmationparameter that bypasses the confirmation dialog - Updated action factories and executor to propagate the skip confirmation flag through the action creation pipeline
- Added shift key detection in the menu handler to determine when to skip confirmation
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| MiniSim/Service/Actions.swift | Added skipConfirmation parameter to DeleteAction to conditionally bypass confirmation dialog |
| MiniSim/Service/ActionFactory.swift | Updated factory methods to accept and pass through skipConfirmation parameter |
| MiniSim/Service/ActionExecutor.swift | Modified execute method to accept and forward skipConfirmation parameter |
| MiniSim/Menu.swift | Added shift key detection and passed skipConfirmation flag to action executor |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
dc47e20 to
1b9cf9d
Compare
1b9cf9d to
e7a7ee6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This allows to skip alert when deleting simulators. Pressing shift will delete them without prompt
Changelog:
feat: allow to use shift + click to delete simulators without asking
Test Plan:
Try deleting simulators holding shift