Merged
Conversation
Owner
okwasniewski
left a comment
There was a problem hiding this comment.
Thanks for opening the PR! I've left few comments
okwasniewski
reviewed
Dec 5, 2023
Owner
okwasniewski
left a comment
There was a problem hiding this comment.
Few minor things and we are good to merge
Comment on lines
+11
to
+14
| enum TerminalType: String { | ||
| case terminal = "Terminal" | ||
| case iterm = "iTerm" | ||
| } |
Owner
There was a problem hiding this comment.
Let's name this just Terminaland move it to TerminalApps.swift so its in one place
| static func launchTerminal(terminal: TerminalApp, deviceId: String) throws | ||
| } | ||
|
|
||
| class TerminalService: TerminalServiceProtocol { |
Owner
There was a problem hiding this comment.
Let's leave tests for this module for now - I will add them later
Owner
|
Thanks for contributing @gokul1099! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added logcat feature. Now user can view logcat for every single android device. closes #106