fix: false positive reduction, TUI accuracy and polish#66
Merged
Conversation
Scan profiles (internal/config, internal/verdict): - Agent scan_profile field: strict, content-aware, minimal - content-aware: only MinimalEnforceRules (TC-001, TC-003, TC-006) can block/flag. Everything else logged but verdict is clean. - Tool-scoped rule overrides: apply_to_tools, exempt_tools on RuleAction - TC-005 default config: apply_to_tools: [Bash] only - Default scan profile for auto-registered and hook agents: content-aware - Eliminates false positives on Edit/Write with HTML, SQL, shell patterns TUI improvements: - Event detail: Target, Content preview, Event ID, Session fields - Animated hexagon logo cycling energy through 4 nodes - Feed columns reordered: time, agent, status, tool, latency - Cursor highlight with background color on selected row - classifyStatus uses PolicyDecision instead of RulesTriggered presence Infrastructure: - Gateway starts without backends (hooks-only mode) - Minimal config includes gateway enabled and TC-005 scoped to Bash - Hook handler defaults unknown agents to content-aware profile
- Built-in tool exemptions: drop TC-005/MCPCFG on Bash/Write/Edit, MCPCFG_004/THIRDPARTY_001 on WebFetch/WebSearch - Content tools only enforce TC-001, TC-003, TC-006 - Hooks scan profile limited to content tools, not execution tools - TUI status from PolicyDecision instead of RulesTriggered JSON - Gateway uses ApplyToolScopedOverrides with tool name context - DefaultSeverityVerdict now case-insensitive - Fix nil findings slice producing "null" JSON - Feed columns use lipgloss Width for alignment - Event detail: Hash field, dim border - Logo hexagons active only during agent traffic - Auto-kill previous oktsec instance on startup - Remove TC-005 rule from auto-setup defaults
b1c2b5f to
83d8b42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan