Skip to content

add signed_nonce userfactor type #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bryanapellanes-okta merged 1 commit into from
Aug 8, 2024
Merged

add signed_nonce userfactor type #414

bryanapellanes-okta merged 1 commit into from
Aug 8, 2024

Conversation

@bryanapellanes-okta
Copy link
Contributor

@bryanapellanes-okta bryanapellanes-okta commented Aug 6, 2024 •
edited
Loading

  • Added SIGNED_NONCE to UserFactor map of constants used for response deserialization

Note - failing tests appear to be environment related and should be addressed with future work; tests pass locally.

@bryanapellanes-okta bryanapellanes-okta force-pushed the OKTA-749014-add-signed-nonce-user-factor-type branch from af52be1 to eecf1db Compare August 7, 2024 14:08
@bryanapellanes-okta bryanapellanes-okta force-pushed the OKTA-749014-add-signed-nonce-user-factor-type branch from eecf1db to 1a549b5 Compare August 7, 2024 14:11
@bryanapellanes-okta bryanapellanes-okta marked this pull request as ready for review August 7, 2024 14:21
@lboynton
Copy link

lboynton commented Aug 7, 2024

Does this partly fix #311 (comment), specifically the KeyError('signed_nonce') error that occurs when FastPass is enabled?

@bryanapellanes-okta
Copy link
Contributor Author

bryanapellanes-okta commented Aug 7, 2024

@lboynton It should at least partly fix the problem described in #311 . It isn't clear if the entirety of the problem described there will be resolved, so we'll leave it open for now until we get further feedback.

@bryanapellanes-okta bryanapellanes-okta merged commit 49757d9 into master Aug 8, 2024
@bryanapellanes-okta bryanapellanes-okta deleted the OKTA-749014-add-signed-nonce-user-factor-type branch August 8, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bretterer bretterer Awaiting requested review from bretterer

@monde monde Awaiting requested review from monde

@laura-rodriguez laura-rodriguez Awaiting requested review from laura-rodriguez

2 more reviewers

@arvindkrishnakumar-okta arvindkrishnakumar-okta arvindkrishnakumar-okta approved these changes

@duytiennguyen-okta duytiennguyen-okta duytiennguyen-okta approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bryanapellanes-okta @lboynton @arvindkrishnakumar-okta @duytiennguyen-okta