Fix for ApiKey not being sent to Authorization Header (#91) #92
+19
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the code and its mustache template to add the key to the Authorization header that is sent to the API
This adjustment prevents an issue theoriginal code had when using a ClientId
Contributor
|
Hi @TriggerAu Thank you so much for identifying this critical bug and proposing the fix! Your analysis in #91 was spot-on - the I've incorporated your solution into #94 which includes:
PR #94 has been merged and will close issues #91 , #86 , and #52 . Since #94 provides a more comprehensive solution with the same core fix you proposed, I'm closing this PR to avoid duplication. Your contribution is greatly appreciated! See: #94 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the code and its mustache template to add the key to the Authorization header that is sent to the API
Fixes Issue #91