Fix "Remove-NullProperties function in JsonHelper.ps1 causes error that the request body was not well-formed" #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
laura-rodriguez
commented
Oct 29, 2024
- Include @TriggerAu's contribution (Add forced casting for Arrays in Remove-NullProperties (#50) #51)
- Update Remove-NullPropertiesFromArray to ensure an array is always returned
- Add tests to verify functionality
- Fix Remove-NullProperties function in JsonHelper.ps1 causes depth overflow error when called #43
- Fix OKTA-743474, OKTA-812302
bryanapellanes-okta
previously approved these changes
Oct 30, 2024
Contributor
bryanapellanes-okta
left a comment
There was a problem hiding this comment.
Looks straight forward 👍
This adds a forced cast inside the method that prevents Powershell from converting a single valued array to an object. This pr does not include changes to the test methods as Im not sure how the team would intend the use case to be tested Its a revisit on #35 Signed-off-by: Laura Rodriguez <rdz.maria.laura@gmail.com>
- Update Remove-NullPropertiesFromArray to ensure an array is always returned - Add tests to verify functionality - Fix #43 Signed-off-by: Laura Rodriguez <rdz.maria.laura@gmail.com>
658677e to
4849f7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.