Skip to content

fix: Return non nil values in abci handlers#515

Merged
rbajollari merged 1 commit intomainfrom
ryan/fix-verify-vote
Sep 17, 2024
Merged

fix: Return non nil values in abci handlers#515
rbajollari merged 1 commit intomainfrom
ryan/fix-verify-vote

Conversation

@rbajollari
Copy link
Copy Markdown
Member

Description

closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@rbajollari rbajollari requested a review from a team as a code owner September 17, 2024 18:03
@rbajollari rbajollari merged commit 960e5e1 into main Sep 17, 2024
@rbajollari rbajollari deleted the ryan/fix-verify-vote branch September 17, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants