Skip to content

feat: Oracle vote extension handler#396

Merged
rbajollari merged 29 commits intomainfrom
ryan/vote-extensions
Apr 10, 2024
Merged

feat: Oracle vote extension handler#396
rbajollari merged 29 commits intomainfrom
ryan/vote-extensions

Conversation

@rbajollari
Copy link
Copy Markdown
Member

@rbajollari rbajollari commented Mar 4, 2024

Description

closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 67.94872% with 100 lines in your changes are missing coverage. Please review.

Project coverage is 16.91%. Comparing base (f1f497e) to head (ed7a984).
Report is 2 commits behind head on main.

Files Patch % Lines
x/oracle/abci/proposal.go 67.54% 37 Missing and 12 partials ⚠️
x/oracle/abci/voteextension.go 64.42% 32 Missing and 5 partials ⚠️
x/oracle/abci/preblocker.go 80.00% 5 Missing and 2 partials ⚠️
x/oracle/abci/util.go 33.33% 4 Missing and 2 partials ⚠️
x/oracle/module.go 0.00% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #396      +/-   ##
==========================================
+ Coverage   16.06%   16.91%   +0.84%     
==========================================
  Files          78       82       +4     
  Lines       18781    19092     +311     
==========================================
+ Hits         3018     3230     +212     
- Misses      15596    15674      +78     
- Partials      167      188      +21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 8, 2024
View reviewed changes
x/oracle/module.go
// It returns no validator updates.
func (am AppModule) EndBlock(ctx context.Context) ([]abci.ValidatorUpdate, error) {
if err := EndBlocker(ctx, am.keeper); err != nil {
if err := oracleabci.EndBlocker(ctx, am.keeper); err != nil {

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods

path flow from Begin/EndBlock to a panic call
@rbajollari rbajollari marked this pull request as ready for review April 2, 2024 23:16
@rbajollari rbajollari requested a review from a team as a code owner April 2, 2024 23:16
adamewozniak
adamewozniak reviewed Apr 4, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@adamewozniak adamewozniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review

@adamewozniak
Copy link
Copy Markdown
Member

adamewozniak commented Apr 4, 2024

Dependency issues will be resolved by merging https://github.com/ojo-network/ojo/pull/405/files

adamewozniak
adamewozniak reviewed Apr 4, 2024
View reviewed changes
adamewozniak
adamewozniak reviewed Apr 9, 2024
View reviewed changes
rbajollari and others added 2 commits April 9, 2024 12:29
@rbajollari
import latest pf version
87c9aeb
@rbajollari @adamewozniak
Update .gitignore
97c881d 
Co-authored-by: Adam Wozniak <29418299+adamewozniak@users.noreply.github.com>
@rbajollari @adamewozniak
Update x/oracle/abci/proposal.go
5ae25dd 
Co-authored-by: Adam Wozniak <29418299+adamewozniak@users.noreply.github.com>
@rbajollari rbajollari mentioned this pull request Apr 9, 2024
Closed
rbajollari and others added 3 commits April 9, 2024 14:37
@rbajollari @adamewozniak
Update x/oracle/abci/voteextension.go
8b67675 
Co-authored-by: Adam Wozniak <29418299+adamewozniak@users.noreply.github.com>
@rbajollari
round 2 pr comments
e47a9e9
@rbajollari
README update
128313a
adamewozniak
adamewozniak approved these changes Apr 9, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@adamewozniak adamewozniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from one lint fix, lgtm

@rbajollari rbajollari merged commit 15abd95 into main Apr 10, 2024
@rbajollari rbajollari deleted the ryan/vote-extensions branch April 10, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamewozniak adamewozniak adamewozniak approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rbajollari @codecov-commenter @adamewozniak @github-advanced-security