Skip to content

Remove obsolete CXX_STD = CXX11 to allow Armadillo 15.0.x migration#12

Merged
oguzhanogreden merged 1 commit intooguzhanogreden:masterfrom
eddelbuettel:master
Oct 24, 2025
Merged

Remove obsolete CXX_STD = CXX11 to allow Armadillo 15.0.x migration#12
oguzhanogreden merged 1 commit intooguzhanogreden:masterfrom
eddelbuettel:master

Conversation

@eddelbuettel
Copy link
Contributor

Armadillo 15.0.* now makes C++14 the minimum compilation standard. For most packages, adapting to it can be very simple, and yours is one of them. In this PR we simply remove the declaration from the reference version of Makevars and Makevars.win -- and no other changes are needed.

Please see issues #475 and below for context, and notably #489 for this first wave of PRs. It would be terrific if you could make an upload to CRAN 'soon' to remove the reliance on C++11 which we needed in the past, but which is by now a hindrance. Please do not hesitate to reach out if I can assist in any way or clarify matters.

/cc @kurthornik

@oguzhanogreden
Copy link
Owner

Thank you for the email notification and the PR.

I'll follow up with an upload to CRAN soon.

@eddelbuettel
Copy link
Contributor Author

Hi @oguzhanogreden let me know if you need a hand or an additional check or anything else. Deadine is coming up this week and you 'own' the packages with the most reverse-dependencies so reaching out again now.

@oguzhanogreden
Copy link
Owner

oguzhanogreden commented Oct 19, 2025

Hey @eddelbuettel, I indeed failed to take care of this, unfortunately...

I have now blocked time for this on the upcoming Friday.

@eddelbuettel
Copy link
Contributor Author

I offered help (e.g. here) and while that (dedicated) time window has elapsed I can try to make myself available if it helped.

CRAN holds the keys for deadlines etc but I will try to help fellow package maintainers as I can. Let me know...

@oguzhanogreden oguzhanogreden merged commit 9a2561f into oguzhanogreden:master Oct 24, 2025
@oguzhanogreden
Copy link
Owner

Submitted now.

Version: 0.9.3
Date: 2025-10-24 12:27:43 UTC
SHA: 0541a80


Thanks for organizing the migration in such a helpful way 🙏

@eddelbuettel
Copy link
Contributor Author

And there it is:

image

Thanks for seeing it through!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants