fix: respect prompt_new_tab_name in mouse click handlers#521
Merged
Conversation
The desktop new-tab button and mobile switcher new-tab target were calling open_new_tab_dialog() unconditionally, ignoring the prompt_new_tab_name config setting. Added checks matching the keyboard path in navigate.rs to skip the dialog when prompt_new_tab_name is false. refs ogulcancelik#517
Collaborator
|
Hi @imrajyavardhan12, thanks for your interest in contributing! New contributors need maintainer approval before opening PRs. This keeps review time focused on accepted work and avoids wasted effort. Herdr is opinionated about how it should look, feel, and work. Feature requests, ideas, questions, contribution proposals, and product-direction checks belong in Discussions, not issues. Next steps:
A discussion, issue, branch, or proposed implementation does not reserve the work and does not mean the PR path is approved. This PR will be closed automatically. See https://github.com/ogulcancelik/herdr/blob/master/CONTRIBUTING.md for more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #517
Summary
The desktop new-tab button and mobile switcher new-tab target were calling
open_new_tab_dialog()unconditionally, ignoring theprompt_new_tab_nameconfig setting. This caused the rename dialog to appear even when users had disabled it.Changes
prompt_new_tab_namechecks in both mouse click handlers (src/app/input/mouse.rslines 440 and 1021)false, the handlers now setrequest_new_tab = trueand return toMode::Terminaldirectly, matching the keyboard shortcut behavior innavigate.rsprompt_new_tab_nameis falseTesting
All 1604 unit tests pass. The fix mirrors the existing keyboard path logic, so behavior is now consistent across input methods.
refs #517