Skip to content

Conversation

@ogrisel
Copy link
Owner

@ogrisel ogrisel commented Apr 4, 2023

@jeremiedbb
Copy link

I just remembered that loky does cache the number of physical cores. And at the time I even wrote a comment saying that it should not change during the lifetime of a program. Unfortunately it doesn't cache the total number of cores.
So I'm in favor of extending the cache for both cpu counts in loky, and to add the cache mechanism in scikit-learn at the same time.

@ogrisel
Copy link
Owner Author

ogrisel commented Apr 5, 2023

@jeremiedbb I updated the PR.

@ogrisel ogrisel merged commit 68d86ef into openmp-only-physical-cores-true-by-default Apr 5, 2023
@ogrisel ogrisel deleted the cache-cpu_count branch April 5, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants