Rename cluster counting method#14
Merged
ogrisel merged 3 commits intoogrisel:wip-enginesfrom Jan 17, 2023
Merged
Conversation
ogrisel
reviewed
Jan 12, 2023
Collaborator
Author
|
Updated to just rename the method. |
ogrisel
approved these changes
Jan 17, 2023
Owner
ogrisel
left a comment
There was a problem hiding this comment.
I would prefer the following as "centers" is misleading. To be it the array of cluster center coordinates in the n_features dim space.
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Collaborator
Author
|
Done. I thought it was the cluster center coordinates that are being passed in to the function. But that was wrong. |
Owner
|
Merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses the "Array API" to get the number of clusters instead of adding a new method to the engine.Rename the engine method used to count distinct clusters.
WDYT?
@ogrisel @fcharras