fix: HasParams for deepObject query params with additionalProperties#1629
Merged
ernado merged 2 commits intoogen-go:mainfrom Feb 23, 2026
Merged
fix: HasParams for deepObject query params with additionalProperties#1629ernado merged 2 commits intoogen-go:mainfrom
ernado merged 2 commits intoogen-go:mainfrom
Conversation
…perties HasParam failed to detect deepObject query parameters when the schema uses additionalProperties (map types) instead of named properties. When Fields was empty, it fell through to a literal key check for the parameter name, but deepObject encoding produces bracket-suffixed keys.
Contributor
Author
|
Force-pushed the linter fix for the related code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HasParam fails for deepObject params with additionalProperties (maps) because Fields is empty and the fallback checks literal key "param" instead of bracket-prefixed keys "param[key]".
This fix allows to create urls as:
https://example.com/customers?filter[name]=John&filter[surname]=Doe