Fix: prevent duplicate case statements in response type switches#1582
Merged
ernado merged 1 commit intoogen-go:mainfrom Nov 24, 2025
Merged
Conversation
Prevents duplicate case statements when multiple response patterns (e.g., 2XX, 3XX) share the same schema reference. Previously, this caused Go compilation errors due to duplicate cases in type switches. The fix introduces uniqueResponseTypes() to filter responses by Type.Name before generating case statements. This is safe because responses with identical type names have the same encoding logic. Includes integration test to prevent regression. Fixes #1
891a270 to
2ea0f36
Compare
ernado
approved these changes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes duplicate case compilation errors when multiple response patterns share the same schema.
Fixes #1
Problem
When an OpenAPI spec defines multiple response patterns (2XX, 3XX) using the same schema, ogen generated duplicate case statements in type switches, causing compilation failures:
Solution
Added
uniqueResponseTypes()function that deduplicates response types byType.Namebefore generating switch cases.This is safe because:
Type.Nameare identicalStatusCodefield, not separate casesExample
Before: Generated duplicate cases (compilation error)
After: Single case handles both patterns
Changes
uniqueResponseTypes()deduplication function ingen/templates.gogen/_template/response_encode.tmplto use deduplicationTesting