feat: pass raw response body in UnexpectedStatusCodeError#1530
Merged
ernado merged 5 commits intoogen-go:mainfrom Sep 17, 2025
Merged
Conversation
A client sometimes encounters a truly unexpected status code from the server for various reasons. The client should not trash the response away then, to instead let the caller know what was going on. In such cases, that bit might be useful for for instance inspection, logging, and/or debugging purposes.
ernado
reviewed
Sep 16, 2025
validate/errors.go
Outdated
| } | ||
| } | ||
|
|
||
| // (Remains here for backwards compatibility) |
Member
There was a problem hiding this comment.
Please add standard deprecation notice instead. https://go.dev/wiki/Deprecated
Like Deprecated: ....
Member
|
Looks ok, please make pipeline green so we can merge this. |
ernado
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A client sometimes encounters a truly unexpected status code from the server for various reasons. The client should not trash the response away then, to instead let the caller know what was going on. In such cases, that bit might be useful for for instance inspection, logging, and/or debugging purposes.