Merged
Conversation
Contributor
Author
|
Hi @ernado, could you please take a look when you have time? |
Member
|
@Sosorevgm can you please rebase to trigger CI/CD pipeline |
80ca464 to
79e292b
Compare
Member
|
Can you please
|
ernado
approved these changes
Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add raw request body to middleware.Request for signature validation use cases
This PR adds a new field RawBody []byte to the middleware.Request struct, allowing middleware to access the raw HTTP request body.
Motivation
In some scenarios — such as validating HMAC or SHA-based signatures — it is necessary to work with the exact raw body of the incoming request. Currently, ogen consumes the request body during decoding, and does not expose it to middleware.
Example
Demo project here
Update:
I found an existing PR that introduces a similar idea: #1505, where the author recovers the body using io.NopCloser.
The goal is the same - to have access to the original body.
Compared to that approach, this PR has the following advantages:
• No need to manually defer r.Body.Close() or wrap the request body with io.NopCloser.
• Middleware receives the raw body directly via middleware.Request.RawBody, so there’s no need to re-read or re-wrap the body again.
This approach keeps the original request lifecycle untouched and adds the raw body as a read-only byte slice for middleware purposes.