fix(gen): wrong package name on external types#1500
Merged
ernado merged 2 commits intoogen-go:mainfrom Sep 16, 2025
Merged
Conversation
c5c1b5b to
da30dfc
Compare
Contributor
Author
|
@tdakkota friendly ping |
Contributor
Author
|
@ernado @tdakkota @shadowspore any chance of getting this in? |
ernado
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The external type was using the base of the package path as package name, thus generating broken code where the name of the package did not match that (e.g. versioned packages where the base is
v2).This PR fixes that by loading the actual package name while loading the type.
Closes #1495