feat: add min/max len for object#1496
Merged
ernado merged 13 commits intoogen-go:mainfrom Sep 22, 2025
Merged
Conversation
Signed-off-by: Sasha Melentyev <sasha@m8.ru>
Member
|
Should we add actual validation for this? |
Contributor
Author
|
Yes, because when I try gen client by zoom openapi I got error about min/maxLength. |
Signed-off-by: Sasha Melentyev <sasha@m8.ru>
Contributor
Author
|
I added test for this case. |
Member
|
Zoom spec would be good.
No, I mean we should add actuall validation, not just allow schema to compile. |
Signed-off-by: Sasha Melentyev <sasha@m8.ru>
Signed-off-by: Sasha Melentyev <sasha@m8.ru>
Signed-off-by: Sasha Melentyev <sasha@m8.ru>
Signed-off-by: Sasha Melentyev <sasha@m8.ru>
Signed-off-by: Sasha Melentyev <sasha@m8.ru>
Signed-off-by: Sasha Melentyev <sasha@m8.ru>
ernado
approved these changes
Sep 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add min/max length for object type
6.4.18 Schema Object -> https://spec.openapis.org/oas/v3.0.0.html#schema-object
And this case have in zoom openapi https://developers.zoom.us/docs/api/