fix: support string enum types in validation#1481
Merged
ernado merged 1 commit intoogen-go:mainfrom Sep 16, 2025
Merged
Conversation
Contributor
Author
|
I'll have a look at the failing CI tests. Edit: done. |
This commit fixes an issue where the `validateEnumValues` would pre-emptively fail if the enum type was set and its type was not an integer. Since string types are also supported, this update to the validation check ensures that this can be properly processed later. Signed-off-by: Alexander Jung <alex@nder.sh>
1c01ab3 to
95d50ee
Compare
ernado
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue where the
validateEnumValueswould pre-emptively fail if the enum type was set and its type was not an integer. Since string types are also supported, this update to the validation check ensures that this can be properly processed later.