fix(ogenregex): Support \p{...} and \P{...} format for Go regexp#1475
Merged
1 commit merged intoogen-go:mainfrom Jun 15, 2025
Merged
fix(ogenregex): Support \p{...} and \P{...} format for Go regexp#14751 commit merged intoogen-go:mainfrom
\p{...} and \P{...} format for Go regexp#14751 commit merged intoogen-go:mainfrom
Conversation
4a5705f to
b5c900b
Compare
b5c900b to
5adf7dc
Compare
Contributor
Author
|
Fixed commit-lint error and test passed. |
ghost
approved these changes
Jun 15, 2025
Contributor
Author
|
Thanks for the merge :) |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1466
Go's regexp supports
\p{...}and\P{...}, soogenregex.Convertfunction should keep these formats in regexp pattern.This patch doesn't check actual properties because supported properties depend on Go version.
e.g. Go v1.25 supports more properties: golang/go#70780