Skip to content

[FW][FIX] stock: couldn't unreserve mixed tracking stock#66355

Closed
fw-bot wants to merge 1 commit intoodoo:saas-14.1from
odoo-dev:saas-14.1-12.0-fix-mix-reservation-arm-_C1x-fw
Closed

[FW][FIX] stock: couldn't unreserve mixed tracking stock#66355
fw-bot wants to merge 1 commit intoodoo:saas-14.1from
odoo-dev:saas-14.1-12.0-fix-mix-reservation-arm-_C1x-fw

Conversation

@fw-bot
Copy link
Copy Markdown
Contributor

@fw-bot fw-bot commented Feb 17, 2021

  • Install stock

  • Go to Inventory > Configuration > Settings and enable "Lots" and "Storage Locations"

  • Create a Product tracked By Lots (i.e. Product X)

  • Go to Inventory > Operations > Inventory Adjustments

  • Create an Inventory Adjustment for Product X:

    Product | Location | Lot/SN | Real Quantity


Product X  |   WH/Stock   |   LOT 01   |       20
Product X  |   WH/Stock   |            |       10
  • Validate Inventory
  • Go to Inventory > Operations > Transfers and create one:
    • Source Location: WH/Stock
    • Destination Location: WH/Stock/Shelf1
    • Operation Type: Internal Transfers
    • Operations:
      [Product: Product X, Initial Demand: 25]
  • Save Transfer, Mark As Todo and Check availability
  • Click on list icon of Operation line for Product X to display Detailed Operations
  • 20 units of LOT 01 and 5 units without lot have been reserved
  • Set LOT 01 for the 5 reserved units without lot and confirm
  • Open Detailed Operations again
  • There are now 20 units of LOT 01 and 5 units of LOT 01
  • Remove the row with 5 units and confirm
  • Check availability and open Detailed Operation
  • There is now only a row with 25 reserved units of LOT 01
  • Unreserve
    The following errror is raised:
    "It is not possible to unreserve more products of P than you have in stock."

It happens because the system is not able to manage quants with lots and
wihtout lots at the same time. When modifying the move line to 25
reserved units. It's composed of 20 quants with lot and 5 quants without
lot. And when unreserving it will check if there is a quants with 25
units with the lot and if it's not found 25 units without lot. But never
25 units of quants with lots and without lots.

opw-2419444

Close #64497

Forward-Port-Of: #66029
Forward-Port-Of: #65057

- Install stock
- Go to Inventory > Configuration > Settings and enable "Lots" and "Storage Locations"
- Create a Product tracked By Lots (i.e. Product X)
- Go to Inventory > Operations > Inventory Adjustments
- Create an Inventory Adjustment for Product X:

     Product   |   Location   |   Lot/SN   |   Real Quantity
 -------------------------------------------------------------
    Product X  |   WH/Stock   |   LOT 01   |       20
    Product X  |   WH/Stock   |            |       10

- Validate Inventory
- Go to Inventory > Operations > Transfers and create one:
  * Source Location: WH/Stock
  * Destination Location: WH/Stock/Shelf1
  * Operation Type: Internal Transfers
  * Operations:
    [Product: Product X, Initial Demand: 25]
- Save Transfer, Mark As Todo and Check availability
- Click on list icon of Operation line for Product X to display Detailed Operations
- 20 units of LOT 01 and 5 units without lot have been reserved
- Set LOT 01 for the 5 reserved units without lot and confirm
- Open Detailed Operations again
- There are now 20 units of LOT 01 and 5 units of LOT 01
- Remove the row with 5 units and confirm
- Check availability and open Detailed Operation
- There is now only a row with 25 reserved units of LOT 01
- Unreserve
The following errror is raised:
"It is not possible to unreserve more products of P than you have in stock."

It happens because the system is not able to manage quants with lots and
wihtout lots at the same time. When modifying the move line to 25
reserved units. It's composed of 20 quants with lot and 5 quants without
lot. And when unreserving it will check if there is a quants with 25
units with the lot and if it's not found 25 units without lot. But never
25 units of quants with lots and without lots.

opw-2419444

Close odoo#64497

X-original-commit: 3b59d0b
@robodoo robodoo added conflict There was an error while creating this forward-port PR forwardport This PR was created by @fw-bot labels Feb 17, 2021
@robodoo
Copy link
Copy Markdown
Contributor

robodoo commented Feb 17, 2021

Pull request status dashboard

@fw-bot
Copy link
Copy Markdown
Contributor Author

fw-bot commented Feb 17, 2021

Ping @amoyaux
Cherrypicking 2777bad of source #65057 failed

stderr:

13:26:48.454690 git.c:344               trace: built-in: git cherry-pick 2777bad2e8f7c91c79401ae6b018fb75313a2db4
error: could not apply 2777bad2e8f... [FIX] stock: couldn't unreserve mixed tracking stock
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

@C3POdoo C3POdoo added the OE the report is linked to a support ticket (opw-...) label Feb 17, 2021
@d-fence
Copy link
Copy Markdown
Contributor

d-fence commented Mar 17, 2021

Hi, the saas-14.1 branch reached end of life ... If you want this fix to reach 14.2 and master you have to re-create a new one.

@rdeodoo
Copy link
Copy Markdown
Contributor

rdeodoo commented Jul 30, 2021

@amoyaux Looks like this one was forgotten (may need to r+ now, to create a correct forward-port to master since there is new versions in the meantime) or just close it, not sure what happened after moc messages

@rdeodoo
Copy link
Copy Markdown
Contributor

rdeodoo commented Aug 27, 2021

@amoyaux

@amoyaux
Copy link
Copy Markdown
Contributor

amoyaux commented Aug 27, 2021

#75700

@amoyaux amoyaux closed this Aug 27, 2021
@xmo-odoo xmo-odoo deleted the saas-14.1-12.0-fix-mix-reservation-arm-_C1x-fw branch March 7, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conflict There was an error while creating this forward-port PR forwardport This PR was created by @fw-bot OE the report is linked to a support ticket (opw-...)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants