[fmt] fix zero-padding behaviour of numbers#2573
Merged
Merged
Conversation
- when formatting a negative number with left zero-padding we expect the padding to be placed between the minus (-) sign and the number - currently the padding is placed before the sign
Contributor
Author
|
Was not entirely sure if we require a guard to check if the string is non-empty in the if statement. It is currently only used in the context of padding numbers and so we can expect it to be non-empty. However, it could be used in a more general case and then we would ensure that we don't have an out-of-bounds error... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2431 and fixes #2328