Conversation
The function now checks if the file is already present on the bridge. If so, do not copy. Otherwise, copy it and assign the permissions 555 to the new file so any user can run it but don't do any modifications. Closes #4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function
cmsysbot.utils.session.Session.copy_to_bridge()now checks first if the file is already present on the bridge computer. If so, don't perform any copy. Otherwise, the file will be copied to the bridge.When a plugin is copied to the bridge (because its going to be executed), the copy of the bridge path will have assigned the permissions 555, allowing any user to execute it, but preventing undesired modifications.
Closes #4