Add a new look-and-feel for the web UI.#258
Closed
ewanmellor wants to merge 4 commits intoocurrent:masterfrom
ewanmellor:ui-restyle
Closed
Add a new look-and-feel for the web UI.#258ewanmellor wants to merge 4 commits intoocurrent:masterfrom ewanmellor:ui-restyle
ewanmellor wants to merge 4 commits intoocurrent:masterfrom
ewanmellor:ui-restyle
Conversation
talex5
reviewed
Apr 13, 2021
talex5
reviewed
Apr 13, 2021
Contributor
Author
I have rebased, fixed the failing tests, and addressed all the other comments inline. I have addressed the narrow-screen issue above by making the This is now ready for review again. Note that this is rebased on top of PR #255 , since there is now a dependency (for the graphviz helper functions). |
This adds Dot.digraph. Signed-off-by: Ewan Mellor <ewan@tarides.com>
This adds a static module, which serves the file from a specified docroot. Hook this in to the routes under /images/*. Signed-off-by: Ewan Mellor <ewan@tarides.com>
This adds Roboto / Roboto Mono as web fonts, and adds highlight colors for table heading and the nav menu based on the OCaml logo. It adds the logo itself to the nav bar and the favicon. For the Graphviz diagrams, set the node color (i.e. the box outline color) to match the fill. This makes the boxes less heavy on the page, because they no longer have the black border. Set the default font for the graph, node, and edge options to use Roboto. This changes the unit test expected output to include the options. Lots of padding and spacing adjustments too. Signed-off-by: Ewan Mellor <ewan@tarides.com>
|
|
||
| Note that we ignore the given path, and we use the Context.uri instead. | ||
| The routes package has added a wildcard option | ||
| (https://github.com/anuragsoni/routes/pull/118) but this has not been |
Member
There was a problem hiding this comment.
This has been released as 1.0.0
Merged
Contributor
|
Most of these changes have been merged as part of #315, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds Roboto / Roboto Mono as web fonts, and adds highlight colors
for table heading and the nav menu based on the OCaml logo. It adds the
logo itself to the nav bar and the favicon.
This adds a static module, which serves static files from a specified
docroot. Hook this in to the routes under /images/*.
Lots of padding and spacing adjustments too.
Set the diagram node color (i.e. the box outline color) to match the fill.
This makes the boxes less heavy on the page, because they no longer have
the black border.
Signed-off-by: Ewan Mellor ewan@tarides.com