Record commit messages and display them on hover on commit IDs#356
Merged
art-w merged 5 commits intoocurrent:mainfrom May 11, 2022
Merged
Record commit messages and display them on hover on commit IDs#356art-w merged 5 commits intoocurrent:mainfrom
art-w merged 5 commits intoocurrent:mainfrom
Conversation
6e16fca to
9bd5bc1
Compare
Contributor
|
It looks very good (including the ocurrent patch!) 💯 I think we can wait a bit to see if they are willing to include it officially :) |
art-w
approved these changes
Apr 22, 2022
Contributor
Author
Thanks @art-w for the review and your help with working on this. (I still haven't figured out the best workflow to make changes in |
5a82217 to
2a3650a
Compare
Also, explicitly add a dependency on dockerfile because the latest version of OCurrent doesn't depend on dockerfile.
2a3650a to
9bd79eb
Compare
Contributor
Author
|
Updated this PR with a commit which pins the |
9bd79eb to
b56d3ce
Compare
Contributor
|
Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit depends on a modified version of
ocurrentthat fetches the commit messages from GitHub. The PR temporarily points to that commit ofocurrent. I'm not sure if we should wait to merge this PR until we submit that change, or if there's a better way to go about this.