Skip to content

maint: fix spelling errors#897

Merged
wolfy1339 merged 10 commits into
octokit:mainfrom
jsoref:spelling
Mar 4, 2024
Merged

maint: fix spelling errors#897
wolfy1339 merged 10 commits into
octokit:mainfrom
jsoref:spelling

Conversation

@jsoref

@jsoref jsoref commented Feb 18, 2024

Copy link
Copy Markdown
Contributor

Before the change?

After the change?

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these files don't appear to be referenced?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are used to test the schemas for any regressions. They are used with the validate:payloads script

"site_admin": false
},
"body": "Maybe you should use more emojji on this line.",
"body": "Maybe you should use more emoji on this line.",

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically this really misspelled in github, but as this is a mock, i don't think it has to match the real world.

"id": 10696,
"name": "hello-world-npm",
"namespace": "Codertocaat/hello-world-npm",
"namespace": "Codertocat/hello-world-npm",

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like a typo -- at least I can't find it in npm ...

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just an example payload. The package doesn't necessarily exist on npm

@wolfy1339

Copy link
Copy Markdown
Member

The cache/ files are taken from GitHub's docs, and thus we don't control the spelling errors. I wouldn't worry too much about them

@wolfy1339 wolfy1339 added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Feb 18, 2024
@wolfy1339 wolfy1339 changed the title Spelling maint: fix spelling errors Mar 4, 2024
@wolfy1339 wolfy1339 enabled auto-merge (squash) March 4, 2024 02:01
@wolfy1339 wolfy1339 merged commit e0b47e2 into octokit:main Mar 4, 2024
@jsoref jsoref deleted the spelling branch March 4, 2024 02:15
@octokitbot

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 7.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants