Skip to content

feat(examples): add GitHub Enterprise Server versions#841

Merged
nickfloyd merged 2 commits into
octokit:mainfrom
Ethan-Arrowood:patch-1
Sep 11, 2023
Merged

feat(examples): add GitHub Enterprise Server versions#841
nickfloyd merged 2 commits into
octokit:mainfrom
Ethan-Arrowood:patch-1

Conversation

@Ethan-Arrowood

@Ethan-Arrowood Ethan-Arrowood commented Sep 8, 2023

Copy link
Copy Markdown
Contributor

Adds the github enterprise server directories to the package export

Resolves #ISSUE_NUMBER


Before the change?

After the change?

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

Adds the github enterprise server directories to the package export
@wolfy1339 wolfy1339 added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Sep 8, 2023
@kfcampbell

Copy link
Copy Markdown
Contributor

@wolfy1339 or @gr2m I'm good with this change; do you see a reason not to ship it?

@wolfy1339

Copy link
Copy Markdown
Member

The GHES examples aren't kept up-to-date
The GHES versions there are outdated

Comment thread payload-examples/package.json Outdated
Co-authored-by: wolfy1339 <4595477+wolfy1339@users.noreply.github.com>
@Ethan-Arrowood

Copy link
Copy Markdown
Contributor Author

Would love to get these uptodate. How could I help?

@gr2m gr2m left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind

@gr2m gr2m changed the title Add GitHub Enterprise Server examples to package.json "files" feat(examples): add GitHub Enterprise Server versions Sep 8, 2023
@nickfloyd nickfloyd merged commit 1983486 into octokit:main Sep 11, 2023
@octokitbot

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 7.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants