Skip to content

fix: declare pull_request auto_merge properties as string|null#829

Merged
wolfy1339 merged 3 commits into
octokit:mainfrom
ZauberNerd:fix-automerge-schema
Sep 16, 2023
Merged

fix: declare pull_request auto_merge properties as string|null#829
wolfy1339 merged 3 commits into
octokit:mainfrom
ZauberNerd:fix-automerge-schema

Conversation

@ZauberNerd

Copy link
Copy Markdown
Contributor

See: https://docs.github.com/en/webhooks-and-events/webhooks/webhook-events-and-payloads#pull_request

Resolves #828


Before the change?

  • The properties enabled_by, commit_title and commit_message did not allow null

After the change?

  • The properties enabled_by, commit_title and commit_message are nullable

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@wolfy1339 wolfy1339 added the Type: Bug Something isn't working as documented label Aug 17, 2023
@kfcampbell

Copy link
Copy Markdown
Contributor

Looks like the test failures are related to linting currently, which should be easy enough to fix.

@wolfy1339 wolfy1339 merged commit c8983a4 into octokit:main Sep 16, 2023
@octokitbot

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 7.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Type: Bug Something isn't working as documented

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[BUG]: pull_request.auto_merge properties should allow string or null

4 participants