Skip to content

feat: add support for deployment_review event#816

Merged
wolfy1339 merged 7 commits into
mainfrom
deployment-review
Aug 10, 2023
Merged

feat: add support for deployment_review event#816
wolfy1339 merged 7 commits into
mainfrom
deployment-review

Conversation

@wolfy1339

@wolfy1339 wolfy1339 commented Jul 13, 2023

Copy link
Copy Markdown
Member

Resolves #555

Behavior

Before the change?

  • The deployment_review event was not a supported event

After the change?

  • Adds definitions for the deplyment_review event

Other information

  • Since this event is completely undocumented, one has to infer the types from the other schemas and from user gathered payloads

Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Feature/model/API additions: Type: Feature

wolfy1339 added 4 commits July 13, 2023 18:01
@wolfy1339
build(cache): add some trickery so examples regenerate
a2c461a
@wolfy1339
feat: new deployment_review event
6644b76 
This event is completely undocumented, and the types are inferred from the payload and other schemas
@wolfy1339
fix: optimise schema
f2dc6bc
@wolfy1339
build: generate types
772b415
@wolfy1339 wolfy1339 added the Type: Feature New feature or request label Jul 13, 2023
@wolfy1339 wolfy1339 mentioned this pull request Jul 13, 2023
Closed
@JamieMagee

JamieMagee commented Aug 9, 2023

Copy link
Copy Markdown
Member

Event documentation is available here

@wolfy1339 wolfy1339 marked this pull request as ready for review August 10, 2023 00:56
@wolfy1339

wolfy1339 commented Aug 10, 2023

Copy link
Copy Markdown
Member Author

This is now ready to go 🚀

@wolfy1339 wolfy1339 merged commit 4e36ca2 into main Aug 10, 2023
@wolfy1339 wolfy1339 deleted the deployment-review branch August 10, 2023 17:15
@octokitbot

octokitbot commented Aug 10, 2023

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 7.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JamieMagee JamieMagee JamieMagee approved these changes

Assignees

No one assigned

Labels

released Type: Feature New feature or request

Projects

🧰 Octokit Active
Status: 🏗 In progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for deployment_review event

3 participants

@wolfy1339 @JamieMagee @octokitbot