Skip to content

[BUG]: discussion-comment : $.category.node_id is missing #959

@pascal-botpress

Description

@pascal-botpress

What happened?

The webhook documentation says that for discussion-comment, the category's node id is sent in the payload. However, this property appears to be missing from the Octokit type definition, so I've had to resort to casting webhook responses as DiscussionCommentCreatedEvent & { discussion: { category: { node_id: string } } }.

Versions

@octokit/webhooks-types version 6.10.0, but it's still unfixed in the main branch

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Metadata

Metadata

Assignees

No one assigned

    Labels

    Status: TriageThis is being looked at and prioritizedType: BugSomething isn't working as documentedreleased

    Type

    No type
    No fields configured for issues without a type.

    Projects

    Status
    ✅ Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions