Skip to content

feat: upgrade runner to Node 20#293

Merged
gr2m merged 2 commits intooctokit:mainfrom
quantifica:main
Mar 6, 2024
Merged

feat: upgrade runner to Node 20#293
gr2m merged 2 commits intooctokit:mainfrom
quantifica:main

Conversation

@aovens-quantifi
Copy link
Contributor

@aovens-quantifi aovens-quantifi commented Feb 1, 2024

Resolves #272

Before the change?

The action currently runs on Node 16, leading to warnings from GitHub

After the change?

This action will now run on Node 20, GitHub's current recommended version

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@github-actions
Copy link

github-actions bot commented Feb 1, 2024

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@gr2m
Copy link
Contributor

gr2m commented Feb 1, 2024

can you please bump the node versions in our actions were we use actions/setup-node@v4 to match the new runtime?

@dobladov dobladov mentioned this pull request Feb 13, 2024
Closed
@olafurw
Copy link

olafurw commented Mar 6, 2024

If this is a valid PR then can it be migrated soon before the transition period.

https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

@gr2m gr2m changed the title Upgrade to Node 20 feat: upgrade runner to Node 20 Mar 6, 2024
gr2m
gr2m approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@gr2m gr2m merged commit aaec6f7 into octokit:main Mar 6, 2024
@octokitbot
Copy link
Contributor

octokitbot commented Mar 6, 2024

🎉 This PR is included in version 2.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gr2m gr2m gr2m approved these changes

Assignees

No one assigned

Labels

released

Projects

🧰 Octokit Active
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[MAINT]: Update runtime to Node 20

5 participants

@aovens-quantifi @gr2m @olafurw @octokitbot @avens19